Skip to content
This repository was archived by the owner on Jul 12, 2020. It is now read-only.

Basic vim bindings #42

Merged
merged 2 commits into from
Dec 8, 2013

Conversation

tomphp
Copy link
Contributor

@tomphp tomphp commented Dec 8, 2013

This is not meant to be a complete implementation of VIM bindings, I just did this so I could start using php-refactor-browser in VIM right now and I thought I'd share it in case others want to try too.

@beberlei
Copy link
Contributor

beberlei commented Dec 8, 2013

This is pretty awesome, however i am wondering if its necessary to reload the buffer after executing the command.

@tomphp
Copy link
Contributor Author

tomphp commented Dec 8, 2013

@beberlei The way it works at the moment (at least in my version of vim) is it's runs the command the a message pops up saying the files content has changed and press L to load it into the buffer. If there's a way to do this automatically that would be fantastic but I have limited experience when it comes to vim development. Is this a simple matter of running :edit? I'll give it a try.

This is by no means complete, it's needs to handle errors from refactor.phar and I couldn't get extract method to leave visual mode but I wanted vim functionality now and since I got something working figured others might like it to...so any help and suggestions are fantistic!

@beberlei
Copy link
Contributor

beberlei commented Dec 8, 2013

Its a very good start, thanks for this contribution!

beberlei added a commit that referenced this pull request Dec 8, 2013
@beberlei beberlei merged commit dcfbb55 into QafooLabs:master Dec 8, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants