Skip to content
This repository was archived by the owner on Jul 12, 2020. It is now read-only.
This repository was archived by the owner on Jul 12, 2020. It is now read-only.

Duplicate class resolution after fix-class-names #31

Closed
@tobyS

Description

@tobyS

Did the following move:

$ git st

#   renamed:    src/main/Qafoo/ChangeTrack/Change.php -> src/main/Qafoo/ChangeTrack/Analyzer/Change.php

The refactoring yields the following diff:

--- a/src/main/Qafoo/ChangeTrack/ChangeSet/Diff/LineChangeFeed/ChunkLineFeedGenerator.php
+++ b/src/main/Qafoo/ChangeTrack/ChangeSet/Diff/LineChangeFeed/ChunkLineFeedGenerator.php
@@ -4,5 +4,5 @@

 use Qafoo\ChangeTrack\ChangeSet\Diff\LineChangeFeed;
-use Qafoo\ChangeTrack\Change;
+use Qafoo\ChangeTrack\Analyzer\Change;

 use Arbit\VCSWrapper\Diff;
@@ -27,5 +27,5 @@
             switch ($line->type) {
                 case Diff\Line::ADDED:
-                    yield new Change(null, $lineNumber, Change::ADDED, null, null);
+                    yield new Analyzer\Change(null, $lineNumber, Analyzer\Change::ADDED, null, null);
                     $lineNumber++;
                     break;
…

While the namespace is correcty fixed at the import, the class name is changed in addition to reference the class relative to the Analyzer namespace.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions