loss_fun
parameter validationf for entropic GW functions
#515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
loss_fun
given is valid for all GW functions that take such the argumentMotivation and context / Related issue
Unified approach to handling
loss_fun
parameter for all GW-related functions. Cleaner error message.Also, note that before the changes, oftentimes function relied on the validation to happen rather deep in the call stack, for example in
init_matrix
helper. Which seems rather fragile when making changes in high-level modules (e.g. another set of low-level procedures could be used).How has this been tested (if it applies)
Test cases are updated.
PR checklist