Validate loss_fun
parameter in Gromov-Wasserstein utils
#513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
ot.gromov._utils.init_matrix
raisesValueError
when unknownloss_fun
is given.ot.gromov._utils.init_matrix_semirelaxed
raisesNotImplementedError
forloss_fun='kl_loss'
.ot.gromov._utils.init_matrix_semirelaxed
raisesValueError
for unknownloss_fun
.Motivation and context / Related issue
Error message is rather hard to understand when unsupported loss_fun is used (as the code makes an attempt to call undefined function).
How has this been tested (if it applies)
New test cases are provided.
PR checklist