Overhaul random state management #512
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
This is rather lengthy follow-up for #510. Hopefully I found all cases to update:
random_state
arguments nowMotivation and context / Related issue
To make reproducibility easier.
How has this been tested (if it applies)
Test cases are updated accordingly. It's interesting that previously for some of them (specifically suites from test_gromov) required explicit seeding for tests to work. Now they rely on
random_state
passed into functions and don't break because of global state.PR checklist
I guess new parameters added to the API should be mentioned in the RELEASE file.