Skip to content

fix: unlock share box from uBlock origins #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2021
Merged

Conversation

yammesicka
Copy link
Member

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 16, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 3.61 ⭐ 3.61 ⭐ 0.00
Method Length 52.06 ⭐ 52.06 ⭐ 0.00
Working memory 6.87 🙂 6.87 🙂 0.00
Quality 75.44% 75.44% 0.00%
Other metrics Before After Change
Lines 682 682 0
Changed files Quality Before Quality After Quality Change
lms/lmsweb/views.py 75.31% ⭐ 75.31% ⭐ 0.00%
lms/models/share_link.py 78.06% ⭐ 78.06% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
lms/lmsweb/views.py comment 13 🙂 202 😞 8 🙂 50.15% 🙂 Try splitting into smaller methods
lms/lmsweb/views.py view 8 ⭐ 140 😞 10 😞 56.16% 🙂 Try splitting into smaller methods. Extract out complex expressions
lms/lmsweb/views.py login 5 ⭐ 129 😞 12 😞 56.69% 🙂 Try splitting into smaller methods. Extract out complex expressions
lms/lmsweb/views.py note 6 ⭐ 144 😞 8 🙂 61.90% 🙂 Try splitting into smaller methods
lms/lmsweb/views.py shared_solution 2 ⭐ 84 🙂 10 😞 69.27% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Oct 16, 2021

Codecov Report

Merging #347 (0e2e004) into master (a787de9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #347   +/-   ##
=======================================
  Coverage   84.08%   84.08%           
=======================================
  Files          63       63           
  Lines        2946     2946           
=======================================
  Hits         2477     2477           
  Misses        469      469           
Impacted Files Coverage Δ
lms/lmsweb/views.py 93.11% <100.00%> (ø)
lms/models/share_link.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a787de9...0e2e004. Read the comment docs.

@yammesicka yammesicka merged commit 8d8c41f into master Oct 17, 2021
@yammesicka yammesicka deleted the ublock-origin-sharebox branch October 17, 2021 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants