Skip to content

fix: create unverified role if not exists #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Conversation

orronai
Copy link
Collaborator

@orronai orronai commented Oct 12, 2021

  • Added creation of the UNVERIFIED role if it doesn't exist - in bootstrap.py file

- Added creation of the UNVERIFIED role if it doesn't exist - in bootstrap.py file
@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #333 (e4c48bb) into master (7762f60) will not change coverage.
The diff coverage is 0.00%.

❗ Current head e4c48bb differs from pull request most recent head b5e034a. Consider uploading reports for the commit b5e034a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #333   +/-   ##
=======================================
  Coverage   83.94%   83.94%           
=======================================
  Files          63       63           
  Lines        2940     2940           
=======================================
  Hits         2468     2468           
  Misses        472      472           
Impacted Files Coverage Δ
lms/lmsdb/bootstrap.py 15.51% <0.00%> (+0.06%) ⬆️
lms/lmsdb/models.py 91.20% <0.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7762f60...b5e034a. Read the comment docs.

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 12, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.07%.

Quality metrics Before After Change
Complexity 1.72 ⭐ 1.68 ⭐ -0.04 👍
Method Length 33.90 ⭐ 33.94 ⭐ 0.04 👎
Working memory 6.58 🙂 6.59 🙂 0.01 👎
Quality 82.29% 82.36% 0.07% 👍
Other metrics Before After Change
Lines 1169 1169 0
Changed files Quality Before Quality After Quality Change
lms/lmsdb/bootstrap.py 78.97% ⭐ 79.25% ⭐ 0.28% 👍
lms/lmsdb/models.py 84.38% ⭐ 84.30% ⭐ -0.08% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
lms/lmsdb/models.py Solution._base_next_unchecked 0 ⭐ 95 🙂 20 ⛔ 57.42% 🙂 Extract out complex expressions
lms/lmsdb/models.py Solution.of_user 10 🙂 125 😞 9 🙂 58.11% 🙂 Try splitting into smaller methods
lms/lmsdb/models.py User.notes 1 ⭐ 92 🙂 18 ⛔ 58.26% 🙂 Extract out complex expressions
lms/lmsdb/bootstrap.py _migrate_column_in_table_if_needed 6 ⭐ 116 🙂 11 😞 59.05% 🙂 Extract out complex expressions
lms/lmsdb/models.py Solution.create_solution 4 ⭐ 135 😞 10 😞 60.60% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@orronai orronai merged commit cf9039f into master Oct 15, 2021
@orronai orronai deleted the support-unverified-role branch October 15, 2021 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants