Skip to content

feat: Join public courses #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 11, 2021
Merged

feat: Join public courses #328

merged 11 commits into from
Oct 11, 2021

Conversation

orronai
Copy link
Collaborator

@orronai orronai commented Oct 6, 2021

  • Added a html template page
  • Added tests
  • Added translations
  • Added the logic of the public courses

- Change user`s last course viewed depending on the saving and deleting of usercourses instances
- Added a test
- Added the html template page
- Added a test
- Added translations
- Added in the backend the logics of the pages and the public courses
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #328 (df95c99) into master (f3ed156) will decrease coverage by 0.13%.
The diff coverage is 68.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
- Coverage   84.08%   83.94%   -0.14%     
==========================================
  Files          63       63              
  Lines        2903     2940      +37     
==========================================
+ Hits         2441     2468      +27     
- Misses        462      472      +10     
Impacted Files Coverage Δ
lms/lmsdb/bootstrap.py 15.45% <0.00%> (-0.63%) ⬇️
lms/lmsweb/views.py 93.05% <94.44%> (+0.06%) ⬆️
lms/lmsdb/models.py 91.36% <100.00%> (+0.09%) ⬆️
lms/models/errors.py 100.00% <100.00%> (ø)
lms/models/users.py 92.59% <100.00%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3ed156...df95c99. Read the comment docs.

@orronai orronai changed the title Join public courses feat: Join public courses Oct 6, 2021
Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome PR! Kudos

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 11, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.02%.

Quality metrics Before After Change
Complexity 2.10 ⭐ 2.12 ⭐ 0.02 👎
Method Length 40.01 ⭐ 40.21 ⭐ 0.20 👎
Working memory 6.62 🙂 6.59 🙂 -0.03 👍
Quality 80.18% 80.20% 0.02% 👍
Other metrics Before After Change
Lines 1999 2074 75
Changed files Quality Before Quality After Quality Change
lms/lmsdb/bootstrap.py 79.29% ⭐ 78.97% ⭐ -0.32% 👎
lms/lmsdb/models.py 84.22% ⭐ 84.38% ⭐ 0.16% 👍
lms/lmsweb/views.py 74.68% 🙂 75.10% ⭐ 0.42% 👍
lms/models/errors.py 94.91% ⭐ 94.91% ⭐ 0.00%
lms/models/users.py 90.65% ⭐ 89.57% ⭐ -1.08% 👎
tests/test_registration.py 78.30% ⭐ 78.01% ⭐ -0.29% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
lms/lmsweb/views.py comment 13 🙂 202 😞 8 🙂 50.15% 🙂 Try splitting into smaller methods
lms/lmsweb/views.py view 8 ⭐ 140 😞 10 😞 56.16% 🙂 Try splitting into smaller methods. Extract out complex expressions
lms/lmsweb/views.py login 5 ⭐ 129 😞 12 😞 56.69% 🙂 Try splitting into smaller methods. Extract out complex expressions
lms/lmsdb/models.py Solution._base_next_unchecked 0 ⭐ 95 🙂 20 ⛔ 57.42% 🙂 Extract out complex expressions
lms/lmsdb/models.py Solution.of_user 10 🙂 125 😞 9 🙂 58.11% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@orronai orronai merged commit 7762f60 into master Oct 11, 2021
@orronai orronai deleted the join-public-courses branch October 11, 2021 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants