#158 - BE - Submit with git

[gal432]

No description provided.

[codecov]

Codecov Report

Merging #323 (d61b301) into master (f18eeca) will increase coverage by 0.64%.
The diff coverage is 96.50%.

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
+ Coverage   83.37%   84.02%   +0.64%     
==========================================
  Files          61       62       +1     
  Lines        2683     2823     +140     
==========================================
+ Hits         2237     2372     +135     
- Misses        446      451       +5     

Impacted Files	Coverage Δ
lms/lmsweb/git_service.py	95.65% <95.65%> (ø)
lms/lmsweb/__init__.py	97.67% <100.00%> (+1.12%)	⬆️
lms/lmsweb/routes.py	100.00% <100.00%> (ø)
lms/lmsweb/views.py	92.94% <100.00%> (+0.14%)	⬆️
lms/models/upload.py	94.00% <100.00%> (+0.25%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f18eeca...d61b301. Read the comment docs.

[yammesicka]

Awesome work! I've added few insights :)

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.18%.

Quality metrics	Before	After	Change
Complexity	2.63 ⭐	2.58 ⭐	-0.05 👍
Method Length	38.23 ⭐	38.30 ⭐	0.07 👎
Working memory	6.86 🙂	6.87 🙂	0.01 👎
Quality	78.74% ⭐	78.92% ⭐	0.18% 👍

Other metrics	Before	After	Change
Lines	1044	1093	49

Changed files	Quality Before	Quality After	Quality Change
lms/lmsweb/init.py	54.82% 🙂	64.84% 🙂	10.02% 👍
lms/lmsweb/routes.py	99.50% ⭐	99.00% ⭐	-0.50% 👎
lms/lmsweb/views.py	74.73% 🙂	74.72% 🙂	-0.01% 👎
lms/models/upload.py	70.62% 🙂	72.30% 🙂	1.68% 👍
tests/conftest.py	91.28% ⭐	91.35% ⭐	0.07% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
lms/lmsweb/views.py	comment	13 🙂	202 😞	8 🙂	50.15% 🙂	Try splitting into smaller methods
lms/lmsweb/views.py	view	8 ⭐	140 😞	10 😞	56.16% 🙂	Try splitting into smaller methods. Extract out complex expressions
lms/lmsweb/views.py	login	5 ⭐	129 😞	12 😞	56.69% 🙂	Try splitting into smaller methods. Extract out complex expressions
lms/lmsweb/views.py	note	6 ⭐	144 😞	8 🙂	61.90% 🙂	Try splitting into smaller methods
lms/models/upload.py	_upload_to_db	6 ⭐	97 🙂	10 😞	63.48% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[yammesicka]

Awesome job. 2 Non blocking comments

[yammesicka]

Non-blocking: Our code doesn't have >79 chars lines, so if you can split it to 2 pathes it'll be great.

DEFAULT_REPOSITORY_FOLDER = (Path() / "repositories").resolve()
REPOSITORY_FOLDER = os.getenv("REPOSITORY_FOLDER", DEFAULT_REPOSITORY_FOLDER)

[yammesicka]

p should appear after os and before shutil