Skip to content

feat: Change default language to English #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Conversation

orronai
Copy link
Collaborator

@orronai orronai commented Sep 29, 2021

  • Changed all the default python and html language messages to English
  • Created new babel translations file of Hebrew language
  • Fixed disabling mail system

- Changed all the default python and html language messages to English
- Created new babel translations file of Hebrew language
- Fixed disabling mail system
@sourcery-ai
Copy link

sourcery-ai bot commented Sep 29, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 2.24 ⭐ 2.24 ⭐ 0.00
Method Length 38.29 ⭐ 38.29 ⭐ 0.00
Working memory 6.82 🙂 6.82 🙂 0.00
Quality 80.22% 80.22% 0.00%
Other metrics Before After Change
Lines 2144 2165 21
Changed files Quality Before Quality After Quality Change
lms/lmsdb/models.py 84.53% ⭐ 84.53% ⭐ 0.00%
lms/lmstests/public/identical_tests/services.py 78.59% ⭐ 78.59% ⭐ 0.00%
lms/lmstests/public/linters/services.py 87.73% ⭐ 87.73% ⭐ 0.00%
lms/lmstests/public/unittests/services.py 78.64% ⭐ 78.64% ⭐ 0.00%
lms/lmstests/sandbox/linters/base.py 87.40% ⭐ 87.40% ⭐ 0.00%
lms/lmsweb/views.py 74.55% 🙂 74.55% 🙂 0.00%
lms/lmsweb/forms/change_password.py 88.99% ⭐ 88.99% ⭐ 0.00%
lms/lmsweb/forms/register.py 69.56% 🙂 69.56% 🙂 0.00%
lms/lmsweb/forms/reset_password.py 75.87% ⭐ 75.87% ⭐ 0.00%
lms/lmsweb/tools/validators.py 91.49% ⭐ 91.49% ⭐ 0.00%
lms/models/solutions.py 74.27% 🙂 74.27% 🙂 0.00%
lms/models/users.py 90.65% ⭐ 90.65% ⭐ 0.00%
lms/utils/mail.py 85.34% ⭐ 85.34% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
lms/lmsweb/views.py comment 13 🙂 202 😞 8 🙂 50.15% 🙂 Try splitting into smaller methods
lms/lmsweb/views.py view 8 ⭐ 140 😞 10 😞 56.16% 🙂 Try splitting into smaller methods. Extract out complex expressions
lms/models/solutions.py get_view_parameters 5 ⭐ 132 😞 12 😞 56.34% 🙂 Try splitting into smaller methods. Extract out complex expressions
lms/lmsweb/views.py login 5 ⭐ 129 😞 12 😞 56.69% 🙂 Try splitting into smaller methods. Extract out complex expressions
lms/lmsdb/models.py Solution._base_next_unchecked 0 ⭐ 95 🙂 20 ⛔ 57.42% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #318 (f414eaa) into master (c6155ac) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #318   +/-   ##
=======================================
  Coverage   84.29%   84.29%           
=======================================
  Files          60       60           
  Lines        2578     2578           
=======================================
  Hits         2173     2173           
  Misses        405      405           
Impacted Files Coverage Δ
lms/lmstests/public/identical_tests/services.py 78.94% <ø> (ø)
lms/lmstests/public/linters/services.py 100.00% <ø> (ø)
lms/lmsweb/forms/register.py 100.00% <ø> (ø)
lms/lmsweb/forms/reset_password.py 100.00% <ø> (ø)
lms/lmsweb/views.py 91.98% <ø> (ø)
lms/models/solutions.py 98.94% <ø> (ø)
lms/lmsdb/models.py 91.23% <100.00%> (ø)
lms/lmstests/public/unittests/services.py 89.38% <100.00%> (ø)
lms/lmstests/sandbox/linters/base.py 87.23% <100.00%> (ø)
lms/lmsweb/forms/change_password.py 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6155ac...f414eaa. Read the comment docs.

@orronai orronai linked an issue Sep 29, 2021 that may be closed by this pull request
Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW! Seriously you're my hero

@orronai orronai merged commit cf0ec2f into master Oct 1, 2021
@orronai orronai deleted the babel-default-english branch October 1, 2021 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change all files language to English
2 participants