Skip to content

feat: Solution status view #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 28, 2021
Merged

feat: Solution status view #314

merged 6 commits into from
Sep 28, 2021

Conversation

orronai
Copy link
Collaborator

@orronai orronai commented Sep 25, 2021

  • Added two columns of the solution status
  • Added migration
  • Added a test

- Added two columns of status and datetime
- Added migration
@orronai orronai changed the title Solution status view feat: Solution status view Sep 25, 2021
@codecov
Copy link

codecov bot commented Sep 25, 2021

Codecov Report

Merging #314 (032dc7e) into master (33c8dc8) will increase coverage by 0.08%.
The diff coverage is 80.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
+ Coverage   84.17%   84.26%   +0.08%     
==========================================
  Files          60       60              
  Lines        2541     2567      +26     
==========================================
+ Hits         2139     2163      +24     
- Misses        402      404       +2     
Impacted Files Coverage Δ
lms/lmsdb/bootstrap.py 16.86% <16.66%> (-0.01%) ⬇️
lms/lmsdb/models.py 91.23% <100.00%> (+0.34%) ⬆️
lms/lmsweb/views.py 91.98% <100.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33c8dc8...032dc7e. Read the comment docs.

@orronai orronai requested a review from yammesicka September 26, 2021 06:39
@sourcery-ai
Copy link

sourcery-ai bot commented Sep 26, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.15%.

Quality metrics Before After Change
Complexity 1.73 ⭐ 1.75 ⭐ 0.02 👎
Method Length 46.54 ⭐ 46.72 ⭐ 0.18 👎
Working memory 7.40 🙂 7.35 🙂 -0.05 👍
Quality 76.23% 76.38% 0.15% 👍
Other metrics Before After Change
Lines 1996 2055 59
Changed files Quality Before Quality After Quality Change
lms/lmsdb/bootstrap.py 77.74% ⭐ 78.06% ⭐ 0.32% 👍
lms/lmsdb/models.py 84.60% ⭐ 84.53% ⭐ -0.07% 👎
lms/lmsweb/views.py 74.80% 🙂 74.55% 🙂 -0.25% 👎
tests/test_solutions.py 66.67% 🙂 67.75% 🙂 1.08% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
lms/lmsweb/views.py comment 13 🙂 202 😞 8 🙂 50.15% 🙂 Try splitting into smaller methods
tests/test_solutions.py TestSolutionBridge.test_staff_and_user_comments 0 ⭐ 236 ⛔ 12 😞 52.40% 🙂 Try splitting into smaller methods. Extract out complex expressions
tests/test_solutions.py TestSolutionBridge.test_share_solution_function 0 ⭐ 248 ⛔ 11 😞 53.48% 🙂 Try splitting into smaller methods. Extract out complex expressions
lms/lmsweb/views.py view 8 ⭐ 140 😞 10 😞 56.16% 🙂 Try splitting into smaller methods. Extract out complex expressions
lms/lmsweb/views.py login 5 ⭐ 129 😞 12 😞 56.69% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@orronai orronai merged commit d642693 into master Sep 28, 2021
@orronai orronai deleted the solution-status-view branch September 28, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants