-
Notifications
You must be signed in to change notification settings - Fork 34
chore: Upgrade versions #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request introduces 1 alert when merging c22e332 into a04bab5 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging bd991ad into a04bab5 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging e70dc67 into a04bab5 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 518f3ed into a04bab5 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging a055cb2 into a04bab5 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #301 +/- ##
==========================================
+ Coverage 79.80% 83.77% +3.97%
==========================================
Files 59 58 -1
Lines 2451 2435 -16
==========================================
+ Hits 1956 2040 +84
+ Misses 495 395 -100
Continue to review full report at Codecov.
|
This pull request introduces 1 alert when merging be65276 into a04bab5 - view on LGTM.com new alerts:
|
from flask import template_rendered | ||
from flask.testing import FlaskClient | ||
from loguru import logger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not using our logger called log
from lms.utils.log
?
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.20%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
No description provided.