Skip to content

chore: Upgrade versions #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Sep 26, 2021
Merged

chore: Upgrade versions #301

merged 20 commits into from
Sep 26, 2021

Conversation

yammesicka
Copy link
Member

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Sep 15, 2021

This pull request introduces 1 alert when merging c22e332 into a04bab5 - view on LGTM.com

new alerts:

  • 1 for Non-exception in 'except' clause

@lgtm-com
Copy link

lgtm-com bot commented Sep 17, 2021

This pull request introduces 1 alert when merging bd991ad into a04bab5 - view on LGTM.com

new alerts:

  • 1 for Non-exception in 'except' clause

@yammesicka yammesicka marked this pull request as ready for review September 17, 2021 04:33
@lgtm-com
Copy link

lgtm-com bot commented Sep 17, 2021

This pull request introduces 1 alert when merging e70dc67 into a04bab5 - view on LGTM.com

new alerts:

  • 1 for Non-exception in 'except' clause

@lgtm-com
Copy link

lgtm-com bot commented Sep 17, 2021

This pull request introduces 1 alert when merging 518f3ed into a04bab5 - view on LGTM.com

new alerts:

  • 1 for Non-exception in 'except' clause

@lgtm-com
Copy link

lgtm-com bot commented Sep 17, 2021

This pull request introduces 1 alert when merging a055cb2 into a04bab5 - view on LGTM.com

new alerts:

  • 1 for Non-exception in 'except' clause

@codecov
Copy link

codecov bot commented Sep 18, 2021

Codecov Report

Merging #301 (4043e07) into master (0aca325) will increase coverage by 3.97%.
The diff coverage is 76.97%.

❗ Current head 4043e07 differs from pull request most recent head c70d4ea. Consider uploading reports for the commit c70d4ea to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
+ Coverage   79.80%   83.77%   +3.97%     
==========================================
  Files          59       58       -1     
  Lines        2451     2435      -16     
==========================================
+ Hits         1956     2040      +84     
+ Misses        495      395     -100     
Impacted Files Coverage Δ
lms/lmstests/public/unittests/import_tests.py 71.42% <0.00%> (ø)
lms/lmstests/public/unittests/tasks.py 70.00% <40.00%> (-16.67%) ⬇️
lms/lmstests/sandbox/linters/tasks.py 75.00% <60.00%> (-13.24%) ⬇️
lms/lmstests/sandbox/linters/base.py 87.23% <66.66%> (-4.88%) ⬇️
lms/lmstests/public/unittests/services.py 89.38% <76.00%> (-7.10%) ⬇️
lms/lmstests/public/unittests/executers.py 64.70% <80.00%> (+1.41%) ⬆️
lms/lmstests/public/linters/tasks.py 90.47% <88.88%> (+3.80%) ⬆️
lms/lmsdb/bootstrap.py 16.12% <100.00%> (+16.12%) ⬆️
lms/lmstests/public/general/tasks.py 100.00% <100.00%> (+12.50%) ⬆️
lms/lmstests/public/identical_tests/services.py 78.94% <100.00%> (+0.37%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aca325...c70d4ea. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Sep 18, 2021

This pull request introduces 1 alert when merging be65276 into a04bab5 - view on LGTM.com

new alerts:

  • 1 for Non-exception in 'except' clause

from flask import template_rendered
from flask.testing import FlaskClient
from loguru import logger
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using our logger called log from lms.utils.log?

@sourcery-ai
Copy link

sourcery-ai bot commented Sep 26, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.20%.

Quality metrics Before After Change
Complexity 1.44 ⭐ 1.41 ⭐ -0.03 👍
Method Length 43.48 ⭐ 44.51 ⭐ 1.03 👎
Working memory 6.91 🙂 6.83 🙂 -0.08 👍
Quality 78.59% 78.79% 0.20% 👍
Other metrics Before After Change
Lines 2939 2943 4
Changed files Quality Before Quality After Quality Change
lms/lmsdb/bootstrap.py 76.59% ⭐ 76.55% ⭐ -0.04% 👎
lms/lmstests/public/general/tasks.py 86.27% ⭐ 87.70% ⭐ 1.43% 👍
lms/lmstests/public/identical_tests/services.py 78.65% ⭐ 78.59% ⭐ -0.06% 👎
lms/lmstests/public/identical_tests/tasks.py 92.67% ⭐ 92.26% ⭐ -0.41% 👎
lms/lmstests/public/linters/services.py 87.73% ⭐ 87.73% ⭐ 0.00%
lms/lmstests/public/linters/tasks.py 93.30% ⭐ 90.09% ⭐ -3.21% 👎
lms/lmstests/public/unittests/executers.py 92.72% ⭐ 92.08% ⭐ -0.64% 👎
lms/lmstests/public/unittests/import_tests.py 78.08% ⭐ 77.96% ⭐ -0.12% 👎
lms/lmstests/public/unittests/services.py 74.03% 🙂 78.64% ⭐ 4.61% 👍
lms/lmstests/public/unittests/tasks.py 90.50% ⭐ 87.58% ⭐ -2.92% 👎
lms/lmstests/sandbox/linters/base.py 87.69% ⭐ 87.40% ⭐ -0.29% 👎
lms/lmstests/sandbox/linters/python.py 86.31% ⭐ 85.68% ⭐ -0.63% 👎
lms/lmstests/sandbox/linters/sql.py 86.02% ⭐ 86.16% ⭐ 0.14% 👍
lms/lmstests/sandbox/linters/tasks.py 85.18% ⭐ 81.94% ⭐ -3.24% 👎
lms/lmsweb/views.py 74.25% 🙂 74.25% 🙂 0.00%
tests/conftest.py 92.02% ⭐ 91.92% ⭐ -0.10% 👎
tests/test_auto_solution_solver.py 82.72% ⭐ 84.79% ⭐ 2.07% 👍
tests/test_download_file.py 83.79% ⭐ 83.80% ⭐ 0.01% 👍
tests/test_exercise_unit_tests.py 90.61% ⭐ 89.94% ⭐ -0.67% 👎
tests/test_notes.py 56.29% 🙂 56.22% 🙂 -0.07% 👎
tests/test_registration.py 75.95% ⭐ 75.95% ⭐ 0.00%
tests/test_solutions.py 65.71% 🙂 66.67% 🙂 0.96% 👍
tests/test_sql_linter.py 92.35% ⭐ 92.35% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
tests/test_notes.py TestNotes.test_notes 0 ⭐ 268 ⛔ 13 😞 49.23% 😞 Try splitting into smaller methods. Extract out complex expressions
lms/lmsweb/views.py comment 13 🙂 202 😞 8 🙂 50.15% 🙂 Try splitting into smaller methods
tests/test_solutions.py TestSolutionBridge.test_staff_and_user_comments 0 ⭐ 236 ⛔ 12 😞 52.40% 🙂 Try splitting into smaller methods. Extract out complex expressions
tests/test_solutions.py TestSolutionBridge.test_share_solution_function 0 ⭐ 248 ⛔ 11 😞 53.48% 🙂 Try splitting into smaller methods. Extract out complex expressions
tests/test_solutions.py TestSolutionBridge.test_user_comments 0 ⭐ 195 😞 11 😞 56.89% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@yammesicka yammesicka merged commit ad7f8d0 into master Sep 26, 2021
@yammesicka yammesicka deleted the upgrade-versions branch September 26, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants