feat: Add change password and forgot my password #299
Conversation
orronai
commented
Sep 14, 2021
orronai
commented
- Added tests
- Added form backend
- Added template and css style files
- Added a html template of the signup page - Added a href button to the signup page from the login page - Added the form of the signup to the backend and db
- Added confirmation email system - Added some tests
… add-signup-page
- Added a unique salt into confirmation link for each user - Added a test
- Added few _('...') instead of some english phrases
- Moved out the auth logic into models/users
- Added MAIL_DEFAULT_SENDER variable to the config
- Changed the retrieve_salt method
…ed an error message to the UnhashedPasswordError
- Added tests - Added a ref link from user's page - Added the form background - Added the template and the css style
|
This pull request introduces 1 alert when merging e3e633d into a04bab5 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging e1651c7 into a04bab5 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 418437d into e81fd6f - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 33da242 into cd74a56 - view on LGTM.com new alerts:
|
| with db_config.database.transaction(): | ||
| for user in table: | ||
| user.uuid = uuid4() | ||
| user.save() |
There was a problem hiding this comment.
Can't we save at the end of the transaction? I think it would take significantly less time
… add-change-password
|
This pull request introduces 1 alert when merging 1ca6102 into cd74a56 - view on LGTM.com new alerts:
|
tests/test_users.py
Outdated
| client.post('/change-password', data={ | ||
| 'current_password': 'wrong pass', | ||
| 'password': 'some_password', | ||
| 'confirm': 'some_password', | ||
| }, follow_redirects=True) |
There was a problem hiding this comment.
Might be better to extract it to a function
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.25%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
