Skip to content

fix: Unicode Error while downloading issue #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2021

Conversation

orronai
Copy link
Collaborator

@orronai orronai commented Mar 7, 2021

  • Encoded the download name to utf-8

- Encoded the download name to utf-8
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 7, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.11%.

Quality metrics Before After Change
Complexity 4.10 ⭐ 4.10 ⭐ 0.00
Method Length 47.11 ⭐ 47.19 ⭐ 0.08 👎
Working memory 9.50 🙂 9.55 🙂 0.05 👎
Quality 70.07% 🙂 69.96% 🙂 -0.11% 👎
Other metrics Before After Change
Lines 436 436 0
Changed files Quality Before Quality After Quality Change
lms/lmsweb/views.py 70.07% 🙂 69.96% 🙂 -0.11% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
lms/lmsweb/views.py comment 13 🙂 202 😞 19 ⛔ 34.26% 😞 Try splitting into smaller methods. Extract out complex expressions
lms/lmsweb/views.py login 7 ⭐ 135 😞 16 ⛔ 48.68% 😞 Try splitting into smaller methods. Extract out complex expressions
lms/lmsweb/views.py view 7 ⭐ 134 😞 12 😞 54.17% 🙂 Try splitting into smaller methods. Extract out complex expressions
lms/lmsweb/views.py note 6 ⭐ 144 😞 9 🙂 59.69% 🙂 Try splitting into smaller methods
lms/lmsweb/views.py shared_solution 2 ⭐ 84 🙂 14 😞 62.66% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@codecov
Copy link

codecov bot commented Mar 7, 2021

Codecov Report

Merging #271 (c8cb3d4) into master (bfe8036) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #271   +/-   ##
=======================================
  Coverage   78.98%   78.98%           
=======================================
  Files          55       55           
  Lines        2346     2346           
=======================================
  Hits         1853     1853           
  Misses        493      493           
Impacted Files Coverage Δ
lms/lmsweb/views.py 88.92% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfe8036...c8cb3d4. Read the comment docs.

@yammesicka yammesicka merged commit 07cafa7 into master May 4, 2021
@yammesicka yammesicka deleted the fix-unicode-download branch May 4, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants