Feat/Basic Email use #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added fastapi mail usage. Added route for sending email in background. Added tests for email use.
added test pass
Set evniroment setting
ivarshav
reviewed
Jan 16, 2021
ivarshav
reviewed
Jan 16, 2021
ivarshav
reviewed
Jan 16, 2021
ivarshav
reviewed
Jan 16, 2021
ivarshav
reviewed
Jan 16, 2021
yammesicka
requested changes
Jan 16, 2021
Changed the way user is being created. Added hypothesis and Faker for making users. Splited the functions of the database to database, user, event. Changed the pytest with skipif. Changed names of the files and some functions.
|
Please change the PR to merge into PythonFreeCourse:develop |
yammesicka
requested changes
Jan 17, 2021
ivarshav
reviewed
Jan 17, 2021
ivarshav
reviewed
Jan 17, 2021
efratush
reviewed
Jan 18, 2021
changed file paths. changed tests to use faker. changed most of the comments on the last commits.
changed it |
Fixed pep8 error. Added current branch support.
Pass for tests
yammesicka
reviewed
Jan 19, 2021
Codecov Report
@@ Coverage Diff @@
## develop #61 +/- ##
===========================================
+ Coverage 98.55% 98.76% +0.21%
===========================================
Files 8 11 +3
Lines 207 243 +36
===========================================
+ Hits 204 240 +36
Misses 3 3
Continue to review full report at Codecov.
|
yammesicka
requested changes
Jan 20, 2021
Fixed the route of the email send. changed testing assertion renamed files and function..
yammesicka
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fastapi mail usage.
Added route for sending email in background.
Added tests for email use.