Skip to content

Feature/showevent #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Feb 25, 2021
Merged

Conversation

nelliei
Copy link
Contributor

@nelliei nelliei commented Feb 16, 2021

Showing upcoming events on the profile page

@ivarshav
Copy link
Contributor

please resolve conflicts :)

1 similar comment
@ivarshav
Copy link
Contributor

please resolve conflicts :)

@codecov-io
Copy link

codecov-io commented Feb 19, 2021

Codecov Report

Merging #303 (fba931a) into develop (2199bf9) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #303      +/-   ##
===========================================
- Coverage    95.27%   95.22%   -0.06%     
===========================================
  Files           80       81       +1     
  Lines         3664     3729      +65     
===========================================
+ Hits          3491     3551      +60     
- Misses         173      178       +5     
Impacted Files Coverage Δ
app/internal/showevent.py 100.00% <100.00%> (ø)
app/routers/profile.py 92.92% <100.00%> (+0.12%) ⬆️
app/routers/event.py 96.45% <0.00%> (-0.64%) ⬇️
app/database/models.py 97.05% <0.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2199bf9...fba931a. Read the comment docs.

Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on the HTMLs. Now let's refactor some of the Python code to be even better :)

@nelliei nelliei requested a review from yammesicka February 21, 2021 21:00
Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I've also added few insights, please take a look

@nelliei nelliei requested a review from yammesicka February 24, 2021 23:26
@yammesicka yammesicka merged commit 31e231c into PythonFreeCourse:develop Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants