Skip to content

Feature/Adding DarkMode option to project #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Feb 25, 2021

Conversation

galzunited
Copy link
Contributor

Added icon to change to dark mode, used js script to change css variables on load.
atm, changed the new view, and the navigated route we have in app

gala added 2 commits February 16, 2021 01:46
# Conflicts:
#	app/static/style.css
#	app/templates/agenda.html
@galzunited galzunited closed this Feb 15, 2021
@galzunited galzunited reopened this Feb 15, 2021
@galzunited galzunited changed the base branch from main to develop February 15, 2021 23:57
@codecov-io
Copy link

codecov-io commented Feb 15, 2021

Codecov Report

Merging #301 (b950219) into develop (f85eb84) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #301   +/-   ##
========================================
  Coverage    95.40%   95.40%           
========================================
  Files           79       79           
  Lines         3549     3549           
========================================
  Hits          3386     3386           
  Misses         163      163           
Impacted Files Coverage Δ
app/routers/audio.py 43.90% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f85eb84...b950219. Read the comment docs.

@galzunited galzunited changed the title Adding DarkMode option to project Feature/Adding DarkMode option to project Feb 16, 2021
gala added 2 commits February 18, 2021 10:56
# Conflicts:
#	app/static/global.css
#	app/templates/base.html
#	app/templates/partials/calendar/navigation.html
#	app/templates/profile.html
Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I've added few insights :)

gala added 3 commits February 19, 2021 01:21
# Conflicts:
#	app/static/grid_style.css
#	app/templates/profile.html
gala added 2 commits February 20, 2021 14:26
# Conflicts:
#	app/templates/base.html
#	app/templates/profile.html
Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I've added few insights

gala and others added 5 commits February 22, 2021 11:21
# Conflicts:
#	app/static/style.css
#	app/templates/base.html
#	app/templates/index.html
#	app/templates/partials/calendar/navigation.html
Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress :)

gala added 2 commits February 25, 2021 11:35
# Conflicts:
#	app/templates/base.html
#	app/templates/invitations.html
#	app/templates/partials/user_profile/middle_content/event_card.html
Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix small issues, send me DM when you're done and let's merge this PR

@yammesicka yammesicka merged commit 266e497 into PythonFreeCourse:develop Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants