Skip to content

feat: busiest day of the week graph #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Feb 22, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion app/internal/agenda_events.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import datetime
from datetime import date, timedelta
from typing import Iterator, List, Optional, Union
from typing import Dict, Iterator, List, Optional, Tuple, Union

import arrow
from sqlalchemy.orm import Session
Expand Down Expand Up @@ -89,3 +89,28 @@ def get_events_in_time_frame(
"""Yields all user's events in a time frame."""
events = get_all_user_events(db, user_id)
yield from filter_dates(events, start_date, end_date)


def get_events_for_the_week(db: Session, user_id: int
) -> Tuple[Union[Iterator[Event], list], Dict]:
WEEK_DAYS = 7
start_date = date.today()
end_date = start_date + timedelta(days=WEEK_DAYS - 1)

events_this_week = get_events_per_dates(
db, user_id, start_date, end_date
)
events_for_graph = {
str(start_date + timedelta(i)): 0 for i in range(WEEK_DAYS)
}
return events_this_week, events_for_graph


def make_dict_for_graph_data(db: Session, user_id: int) -> Dict[str, int]:
"""create a dict with number of events per day for current week"""
events_this_week, events_for_graph = get_events_for_the_week(db, user_id)

for event_obj in events_this_week:
event_date = event_obj.start.date()
events_for_graph[str(event_date)] += 1
return events_for_graph
8 changes: 7 additions & 1 deletion app/routers/agenda.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from collections import defaultdict
from datetime import date, timedelta
import json
from typing import Optional, Tuple

from fastapi import APIRouter, Depends, Request
Expand Down Expand Up @@ -38,6 +39,7 @@ def agenda(
"""Route for the agenda page, using dates range or exact amount of days."""

user_id = 1 # there is no user session yet, so I use user id- 1.

start_date, end_date = calc_dates_range_for_agenda(
start_date, end_date, days
)
Expand All @@ -46,15 +48,19 @@ def agenda(
db, user_id, start_date, end_date
)
events = defaultdict(list)

for event_obj in events_objects:
event_duration = agenda_events.get_time_delta_string(
event_obj.start, event_obj.end
)
events[event_obj.start.date()].append((event_obj, event_duration))

events_for_graph = json.dumps(
agenda_events.make_dict_for_graph_data(db, user_id)
)
return templates.TemplateResponse("agenda.html", {
"request": request,
"events": events,
"start_date": start_date,
"end_date": end_date,
"events_for_graph": events_for_graph,
})
49 changes: 49 additions & 0 deletions app/static/graph.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
function busiestDayOfTheWeekGraph(events) {
events = JSON.parse(events);

const data = Object.values(events);
const labels = Object.keys(events);
const ctx = document.getElementById("myChart");
ctx.style.backgroundColor = "rgba(255, 255, 255, 1)";
const myChart = new Chart(ctx, {
type: "bar",
data: {
labels: labels,
datasets: [{
label: "# Events",
data: data,
backgroundColor: [
"rgba(255, 99, 132, 0.2)",
"rgba(54, 162, 235, 0.2)",
"rgba(255, 206, 86, 0.2)",
"rgba(75, 192, 192, 0.2)",
"rgba(153, 102, 255, 0.2)",
"rgba(255, 159, 64, 0.2)",
"rgba(200, 130, 40, 0.2)",
"rgba(255, 99, 132, 0.2)"
],
borderColor: [
"rgba(255, 99, 132, 1)",
"rgba(54, 162, 235, 1)",
"rgba(255, 206, 86, 1)",
"rgba(75, 192, 192, 1)",
"rgba(153, 102, 255, 1)",
"rgba(255, 159, 64, 1)",
"rgba(200, 130, 64, 1)",
"rgba(255, 99, 132, 1)"
],
borderWidth: 1
}]
}
});
}

function addEventsAfterPageLoaded() {
const element = document.getElementsByClassName("graph")[0];
element.addEventListener("click", function() {
let eventsPerDateData = element.name;
busiestDayOfTheWeekGraph(eventsPerDateData);
}, false);
}

document.addEventListener("DOMContentLoaded", addEventsAfterPageLoaded);
9 changes: 9 additions & 0 deletions app/templates/agenda.html
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,15 @@
<div class="mx-3">
<a class="btn btn-light btn-outline-primary btn-sm" href="/agenda?days=30#dates">{{ gettext("Next 30 days") }}</a>
</div>
<div class="mx-3">
<button class="btn btn-light btn-outline-primary btn-sm graph" type="button" name="{{events_for_graph}}">{{ gettext("Week graph") }}</button>
</div>
</div>

<div class="col-sm-4 col-4 card-body">
<canvas id="myChart" width="400" height="400"></canvas>
<div class="container" id="graph">
</div>
</div>

<div class="pt-4 px-5">
Expand Down
1 change: 1 addition & 0 deletions app/templates/base.html
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@
<!-- This bootstrap version is needed here because of the toggler bug in the beta version-->
<script src="https://stackpath.bootstrapcdn.com/bootstrap/5.0.0-alpha2/js/bootstrap.bundle.min.js" integrity="sha384-BOsAfwzjNJHrJ8cZidOg56tcQWfp6y72vEJ8xQ9w6Quywb24iOsW913URv1IS4GD" crossorigin="anonymous"></script>
<script src="{{ url_for('static', path='/horoscope.js') }}"></script>
<script src="{{ url_for('static', path='/graph.js') }}"></script>
<script type="text/javascript" src="{{ url_for( 'static', path='/audio_settings.js' ) }}"></script>
<script src="{{ url_for('static', path='/joke.js') }}"></script>
<script src="https://cdn.jsdelivr.net/npm/sweetalert2@10"></script>
Expand Down
23 changes: 23 additions & 0 deletions tests/test_agenda_internal.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,26 @@ def test_get_events_per_dates_failure(self, yesterday_event, session):
end=date.today(),
)
assert list(events) == []

def test_make_dict_for_graph_data(self, today_event, session):
events_for_graph = agenda_events.make_dict_for_graph_data(
session,
user_id=today_event.owner_id,
)
assert isinstance(events_for_graph, dict)

def test_get_events_for_the_week_success(self, today_event, session):
events, events_for_graph = agenda_events.get_events_for_the_week(
session,
user_id=today_event.owner_id,
)
assert isinstance(events_for_graph, dict)
assert list(events) == [today_event]

def test_get_events_for_the_week_failure(self, yesterday_event, session):
events, events_for_graph = agenda_events.get_events_for_the_week(
session,
user_id=yesterday_event.owner_id,
)
assert list(events) == []
assert isinstance(events_for_graph, dict)
2 changes: 1 addition & 1 deletion tests/test_agenda_route.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def test_agenda_between_two_dates(
assert b"event 5" in resp.content
assert b"event 6" not in resp.content

def test_agenda_start_bigger_than_end(self, agenda_test_client):
def test_agenda_start_bigger_than_end(self, agenda_test_client, session):
start_date = self.today_date.date()
end_date = (self.today_date - timedelta(days=2)).date()
resp = agenda_test_client.get(
Expand Down