feat: add alembic configuration #220
Conversation
|
review? |
| @@ -0,0 +1,86 @@ | |||
| # A generic, single database configuration. | |||
There was a problem hiding this comment.
Please move all the alembic directory structure into app/database/alembic
There was a problem hiding this comment.
If possible, move the configurations to config.py.example
There was a problem hiding this comment.
Can you please alborate why do that?
this file is runing when you call the alembic into action. this is the standart config that is well documented and it is clear to maintain it. if you whant to override things you can alwayys do it in alembic/env.py file.
but as I see it i wouldn't mix that config with the rest of the custom code configuration.
Ill be glad to hear your opinion about that.
There was a problem hiding this comment.
I'd like to avoid making the user edit multiple configuration files, but now I see that the user shouldn't really touch anything here, so I guess it's cool
…into feature/ellen/add-alembic
…into feature/ellen/add-alembic
Codecov Report
@@ Coverage Diff @@
## develop #220 +/- ##
===========================================
- Coverage 98.05% 97.32% -0.74%
===========================================
Files 73 74 +1
Lines 3194 3218 +24
===========================================
Hits 3132 3132
- Misses 62 86 +24
Continue to review full report at Codecov.
|
| @@ -0,0 +1,86 @@ | |||
| # A generic, single database configuration. | |||
There was a problem hiding this comment.
If possible, move the configurations to config.py.example
| @@ -0,0 +1,86 @@ | |||
| # A generic, single database configuration. | |||
There was a problem hiding this comment.
I'd like to avoid making the user edit multiple configuration files, but now I see that the user shouldn't really touch anything here, so I guess it's cool
I've ran some tests to add and rollback a column. seems to work fine.