Skip to content

Frontend Inheritance Organization (WIP) - Calendar Responsiveness Bug Fix #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

OdeYec
Copy link
Collaborator

@OdeYec OdeYec commented Feb 6, 2021

Encountered a bug in responsiveness that makes the calendar not stretch till the bottom of the browser.
Fixed using some flex/grid magic and changed the scroll listener to be on #calendar-grid instead of the of the whole window.

Also rearranged some files and made better template bases.

Pushing so @aviadamar can continue. Hopefully didn't break anything 🤞

@codecov-io
Copy link

codecov-io commented Feb 6, 2021

Codecov Report

Merging #218 (019aac4) into develop (a39d4d8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #218   +/-   ##
========================================
  Coverage    99.38%   99.38%           
========================================
  Files           37       37           
  Lines         1456     1456           
========================================
  Hits          1447     1447           
  Misses           9        9           
Impacted Files Coverage Δ
app/routers/calendar.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a39d4d8...019aac4. Read the comment docs.

@yammesicka yammesicka merged commit 21faa13 into PythonFreeCourse:develop Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants