Skip to content

Feature/international days #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

liaarbel
Copy link

@liaarbel liaarbel commented Feb 5, 2021

My feature shows which international day it is per day on the page "day".

@codecov-io
Copy link

codecov-io commented Feb 5, 2021

Codecov Report

Merging #210 (b7bc835) into develop (b91708d) will increase coverage by 3.62%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #210      +/-   ##
===========================================
+ Coverage    95.15%   98.77%   +3.62%     
===========================================
  Files           76       64      -12     
  Lines         3382     2862     -520     
===========================================
- Hits          3218     2827     -391     
+ Misses         164       35     -129     
Impacted Files Coverage Δ
app/database/models.py 96.77% <100.00%> (-0.37%) ⬇️
app/internal/international_days.py 100.00% <100.00%> (ø)
app/internal/json_data_loader.py 100.00% <100.00%> (ø)
app/routers/dayview.py 100.00% <100.00%> (+2.52%) ⬆️
app/routers/categories.py 96.55% <0.00%> (-3.45%) ⬇️
app/routers/profile.py 92.72% <0.00%> (-0.07%) ⬇️
app/dependencies.py 100.00% <0.00%> (ø)
app/routers/agenda.py 100.00% <0.00%> (ø)
app/routers/export.py 100.00% <0.00%> (ø)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b91708d...355468a. Read the comment docs.

Copy link
Contributor

@sagizaidor sagizaidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

רעיון מאוד מגניב,
מזמין להתייעץ איתי על עניין הפרונטאנד :)

Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! :) Added few of my insights.

Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Added few of my insights

@yammesicka yammesicka merged commit f85eb84 into PythonFreeCourse:develop Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants