Fix raise #461
Merged
Fix raise #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Handle the 3-argument version of "raise E, V, T". 2. "raise E, V, T" cannot be statically translated safely in general. If V is not a tuple or a (number, string, None) literal, then translate "raise E, V, T" to "from future.utils import raise_; raise_(E, V, T)" and let raise_() handle determining whether V is an instance of E at runtime. Fixes PythonCharmers#387 and PythonCharmers#455.
1. Uncomment the Test_raise tests now that support for tracebacks has been added. Add test_unknown_value() to test for PythonCharmers#455. 2. Run the test_raise_() test now that PythonCharmers#455 is fixed. Add a test for PythonCharmers#387 (raise_(E, V, T) now detects if V is an instance of E and no longer blindly calls E(V)).
|
Thanks for doing this! Looks like there's a couple related test failures: test_chained_exceptions_stacktrace and test_single_exception_stacktrace. Could you take a look at those? Are those related to your change? |
|
These are unrelated... Merging, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #387 and #455 properly, we should defer to
future.utils.raise_()if the type ofVinraise E, V[, T]cannot be inferred.