Skip to content

Fix deprecation warnings for abc module in Python 3.7 #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2019
Merged

Fix deprecation warnings for abc module in Python 3.7 #421

merged 1 commit into from
Mar 13, 2019

Conversation

danyeaw
Copy link
Contributor

@danyeaw danyeaw commented Dec 8, 2018

Fixes #415:

  1. In Python 3, import Mapping from collections.abc, in Python 2 continues to import from collections
  2. Removes an import of collections Iterable since it wasn't being used in the module

Signed-off-by: Dan Yeaw dan@yeaw.me

@danyeaw
Fix deprecation warnings for abc module in Python 3.7
13611f3 
Signed-off-by: Dan Yeaw <dan@yeaw.me>
@danyeaw danyeaw mentioned this pull request Dec 8, 2018
Open
@danyeaw
Copy link
Contributor Author

danyeaw commented Dec 19, 2018

Does someone have time to take a look at this PR? ❤️

@danyeaw
Copy link
Contributor Author

danyeaw commented Feb 2, 2019

@edschofield Is there anything blocking this? 🎁

@jmadler
Copy link
Contributor

jmadler commented Mar 13, 2019

Thanks for doing this!

@jmadler jmadler merged commit afdba55 into PythonCharmers:master Mar 13, 2019
@jmeyers314 jmeyers314 mentioned this pull request Apr 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danyeaw @jmadler