allow mixed string type inputs to misc urllib.parse.* functions #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snarfed
added a commit
to snarfed/webutil
that referenced
this pull request
Mar 24, 2018
specifically PythonCharmers/python-future#321 and PythonCharmers/python-future#331. I tried telling setup.py to use my fork on github instead, with dependency_links=, but that requires users to install with pip install --process-dependency_links, which I don't want to depend on.
...eg urlparse, urlunparse, urlsplit, urlunsplit, urljoin, urldefrag, and parse_qsl. fixes PythonCharmers#273. the original bug result in this kind of exception: ``` Traceback (most recent call last): ... File ".../future/backports/urllib/parse.py", line 387, in urlunparse _coerce_args(*components)) File ".../future/backports/urllib/parse.py", line 115, in _coerce_args raise TypeError("Cannot mix str and non-str arguments") TypeError: Cannot mix str and non-str arguments ```
snarfed
force-pushed
the
urllib_parse_mix_str_and_nonstr
branch
from
1df5b23 to
62b4c35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...eg urlparse, urlunparse, urlsplit, urlunsplit, urljoin, urldefrag, and parse_qsl.
fixes #273.
the original bug result in this kind of exception: