Fix bug where dummy_thread was always imported #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code always import the dummy_thread module even on platforms where the real thread module is available. This caused bugs in other packages that use this import style:
try:
from _thread import interrupt_main # Py 3
except ImportError:
from thread import interrupt_main # Py 2
See ipython/ipython#7079
edschofield
added a commit
that referenced
this pull request
Dec 14, 2014
Fix bug where dummy_thread was always imported
|
Morten, thanks very much for your effort with creating this PR! |
edschofield
added a commit
that referenced
this pull request
Dec 14, 2014
|
This has now gone into v0.14.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code always import the dummy_thread module even on platforms where the real thread module is available. This caused bugs in other packages try to import _thread in pyhton 2.
try:
from _thread import interrupt_main # Py 3
except ImportError:
from thread import interrupt_main # Py 2
See ipython/ipython#7079