Many tests no longer pass

[QuLogic]

When running python setup.py test, I'm seeing basically variations on two errors (50 total errors):

======================================================================
ERROR: test_issue_45 (test_future.test_futurize.TestFuturizeStage1)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/future-0.14.0/tests/test_future/test_futurize.py", line 979, in test_issue_45
    self.convert(code)
  File "/builddir/future-0.14.0/src/future/tests/base.py", line 181, in convert
    _ = self._run_test_script(interpreter=interpreter)
  File "/builddir/future-0.14.0/src/future/tests/base.py", line 347, in _run_test_script
    ErrorClass = (FuturizeError if 'futurize' in script else PasteurizeError)
NameError: global name 'script' is not defined

and

======================================================================
ERROR: test_builtins (test_future.test_standard_library.TestStandardLibraryReorganization)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/future-0.14.0/tests/test_future/test_standard_library.py", line 22, in setUp
    standard_library.install_hooks()
  File "/builddir/future-0.14.0/src/future/standard_library/__init__.py", line 525, in install_hooks
    install_aliases()
  File "/builddir/future-0.14.0/src/future/standard_library/__init__.py", line 486, in install_aliases
    from future.moves.test import support
  File "/builddir/future-0.14.0/src/future/moves/test/support.py", line 10, in <module>
    from test.test_support import *
  File "/usr/lib64/python2.7/test/test_support.py", line 22, in <module>
    import _testcapi
ImportError: No module named _testcapi

This is in a completely clean mock chroot, so maybe there are additional dependencies missing.

[edschofield]

@QuLogic: thanks for reporting this too :)

The tests are all passing on Travis-CI and my Linux and OS X systems. It looks like your Python 2 install doesn't have a working test.test_support module.

I have added code to anticipate that test.test_support may be missing or broken on some Py2 builds, and released this in v0.14.1. This version also fixes the other little bug in the error handler, so you should now see useful output from failed script runs inside futurize unit tests.

I'd be grateful for any further feedback.

[QuLogic]

I skipped over the documentation for now, and I can almost get this to build. The only problem I have is with tests that shell out to the futurize or pasteurize scripts. They end up like this:

PasteurizeError: Command '['/usr/bin/python2', 'pasteurize.py', '-w', '/tmp/tmpGd3JTc/mytestscript.py']' failed with exit status 1
Message: Error running the command /usr/bin/python2 pasteurize.py -w /tmp/tmpGd3JTc/mytestscript.py
env={'PYTHONPATH': '/builddir/build/BUILD/future-0.14.1'}
Contents of file /tmp/tmpGd3JTc/mytestscript.py:
----
def foo(): pass
----
Output: Traceback (most recent call last):
  File "pasteurize.py", line 21, in <module>
    from libpasteurize.main import main
ImportError: No module named libpasteurize.main

Obviously, the problem is that the env is overridden and PYTHONPATH is set to some fixed thing. When building with split build/install steps, I need to be able to set PYTHONPATH. So I think something like this might enable it to work:

class CodeHandler(unittest.TestCase):
    ...
    def setUp(self):
        ...
        pypath = os.getenv('PYTHONPATH')
        if pypath:
            self.env = {'PYTHONPATH': os.getcwd() + os.pathsep + pypath}
        else:
            self.env = {'PYTHONPATH': os.getcwd()}

[edschofield]

@QuLogic: Oops ... it seems I accidentally deleted your last comment while trying to quote it...

You wrote that you discovered that the tests have been split out into the python-test package, and you asked:

I guess it's not a hard requirement now?

Yes, I believe that's true now.

[QuLogic]

So I've been trying out snapshots of the v0.14.x branch. I'm running a simple python3 setup.py test from the source directory (in which only Python 3 was built.) Without any patches, I'm getting some new problem with Python 3 which I hope can be fixed before the release:

======================================================================
ERROR: test_future.test_builtins (unittest.loader.ModuleImportFailure)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib64/python3.3/unittest/case.py", line 422, in _executeTestPart
    function()
  File "/usr/lib64/python3.3/unittest/loader.py", line 32, in testFailure
    raise exception
ImportError: Failed to import test module: test_future.test_builtins
Traceback (most recent call last):
  File "/usr/lib64/python3.3/unittest/loader.py", line 261, in _find_tests
    module = self._get_module_from_name(name)
  File "/usr/lib64/python3.3/unittest/loader.py", line 239, in _get_module_from_name
    __import__(name)
  File "/builddir/build/BUILD/python3-python-future-0.14.2-20141110git02bee8d3.fc20/tests/test_future/test_builtins.py", line 188, in <module>
    from future.backports.test.support import TESTFN, unlink,  run_unittest, check_warnings
  File "/builddir/build/BUILD/python3-python-future-0.14.2-20141110git02bee8d3.fc20/src/future/backports/test/support.py", line 42, in <module>
    import logging.handlers
  File "/usr/lib64/python3.3/logging/handlers.py", line 29, in <module>
    import queue
  File "/builddir/build/BUILD/python3-python-future-0.14.2-20141110git02bee8d3.fc20/src/queue/__init__.py", line 8, in <module>
    raise ImportError('This package should not be accessible on Python 3. '
ImportError: This package should not be accessible on Python 3. Either you are trying to run from the python-future src folder or your installation of python-future is corrupted.

As you can see, somehow the src directory is appearing on the search path, but I'm not totally sure how...

[QuLogic]

PS, there's another import of test_support in tests/test_past/test_olddict.py; it looks like it would only run if using py.test.

[QuLogic]

For now, I've managed to work around the search path problem by using py.test instead, and deleting the extra test_support test from the previous comment.

[edschofield]

I think this is fixed now. Please feel free to reopen this issue or comment if not.