Skip to content

Auto3DSeg CI Test Errors Fix #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 29, 2022

Conversation

mingxin-zheng
Copy link
Contributor

Signed-off-by: Mingxin Zheng 18563433+mingxin-zheng@users.noreply.github.com

Fixes #952 .

Description

  1. fix notebook work_dir sharing causing CI fails

Checks

  • Notebook runs automatically ./runner [-p <regex_pattern>]

Signed-off-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

mingxin-zheng and others added 3 commits September 28, 2022 15:24
Signed-off-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
Signed-off-by: Mingxin Zheng <mingxinz@nvidia.com>
Signed-off-by: Mingxin Zheng <mingxinz@nvidia.com>
@mingxin-zheng mingxin-zheng changed the title [WIP] Auto3DSeg CI Test Errors Fix Auto3DSeg CI Test Errors Fix Sep 29, 2022
@wyli
Copy link
Contributor

wyli commented Sep 29, 2022

Thanks, Could you please confirm that 3000 lines added to the data analyser notebook are necessary?

Signed-off-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
Signed-off-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
@wyli wyli enabled auto-merge (squash) September 29, 2022 11:39
@wyli wyli disabled auto-merge September 29, 2022 11:40
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli enabled auto-merge (squash) September 29, 2022 11:43
@wyli wyli merged commit 5655849 into Project-MONAI:main Sep 29, 2022
@mingxin-zheng mingxin-zheng deleted the fix-auto3dseg-952 branch January 17, 2023 04:00
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
Signed-off-by: Mingxin Zheng
<18563433+mingxin-zheng@users.noreply.github.com>

Fixes Project-MONAI#952 .

### Description
1. fix notebook work_dir sharing causing CI fails

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [ ] Notebook runs automatically `./runner [-p <regex_pattern>]`

Signed-off-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
Signed-off-by: Mingxin Zheng <mingxinz@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testing errors from auto3dseg
2 participants