Skip to content

MAISI Quality check #1789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Aug 21, 2024
Merged

MAISI Quality check #1789

merged 27 commits into from
Aug 21, 2024

Conversation

Can-Zhao
Copy link
Contributor

@Can-Zhao Can-Zhao commented Aug 17, 2024 •
edited
Loading

Fixes #1791 .

Description

Add MAISI Quality check algorithm

Add suggested spacing and output_size to generate results with better quality.

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Can-Zhao and others added 4 commits August 17, 2024 00:58
@Can-Zhao
add quality check
66ae578 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
28f5c96 
for more information, see https://pre-commit.ci
@Can-Zhao
add quality check
7c0bd11 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
91ad068 
for more information, see https://pre-commit.ci
@Can-Zhao Can-Zhao marked this pull request as ready for review August 17, 2024 01:55
Can-Zhao and others added 2 commits August 17, 2024 01:58
@Can-Zhao
refactor
494ed36 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
add docstring
ad5afba 
Signed-off-by: Can Zhao <69829124+Can-Zhao@users.noreply.github.com>
KumoLiu
KumoLiu reviewed Aug 19, 2024
View reviewed changes
@mingxin-zheng
Copy link
Contributor

Thank you for the PR @Can-Zhao . I noticed there are multiple typos in combine (spelled as comebine) in the script generation/maisi/scripts/sample.py. Would you mind replacing all the instances, for example:

  • comebine_label_or
  • comebine_label

mingxin-zheng
mingxin-zheng reviewed Aug 19, 2024
View reviewed changes
mingxin-zheng
mingxin-zheng reviewed Aug 19, 2024
View reviewed changes
mingxin-zheng
mingxin-zheng reviewed Aug 19, 2024
View reviewed changes
@Can-Zhao
Copy link
Contributor Author

  • comebine_label_or

Thanks! Done!

pre-commit-ci bot and others added 7 commits August 20, 2024 15:24
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
38daf8a 
for more information, see https://pre-commit.ci
@Can-Zhao
np.nanmedian
38aacc3 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
Merge branch 'maisi_quality' of https://github.com/Can-Zhao/tutorials …
b10550e 
…into maisi_quality
@Can-Zhao
add logging
d1e096c 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
0db8d90 
for more information, see https://pre-commit.ci
@Can-Zhao
add description on num_label_acceleration_thresh
4e0c77e 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
Merge branch 'maisi_quality' of https://github.com/Can-Zhao/tutorials …
dd57eb3 
…into maisi_quality
@KumoLiu KumoLiu requested a review from mingxin-zheng August 20, 2024 16:48
mingxin-zheng
mingxin-zheng approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@mingxin-zheng mingxin-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

Can-Zhao and others added 6 commits August 20, 2024 19:35
@Can-Zhao
add description on quality check
36b3f0e 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
add description on input FOV
83d8811 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
4e80b50 
for more information, see https://pre-commit.ci
@Can-Zhao
add description on input FOV
2fdedb0 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
add description on input FOV
e1d0821 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
Merge branch 'maisi_quality' of https://github.com/Can-Zhao/tutorials …
88d84cd 
…into maisi_quality
Can-Zhao and others added 6 commits August 20, 2024 19:52
@Can-Zhao
typo
c38039d 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
828c4e3 
for more information, see https://pre-commit.ci
@Can-Zhao
typo
b4b2159 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
add description on input FOV
6caf7ad 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
add description on input FOV
7622ad6 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
update checking on input FOV
8266e9d 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@KumoLiu KumoLiu merged commit 2ec36f2 into Project-MONAI:main Aug 21, 2024
6 checks passed
@Can-Zhao Can-Zhao deleted the maisi_quality branch August 21, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingxin-zheng mingxin-zheng mingxin-zheng approved these changes

@KumoLiu KumoLiu KumoLiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Can-Zhao @mingxin-zheng @KumoLiu