Skip to content

Remove repeated definition in MAISI #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Aug 16, 2024
Merged

Remove repeated definition in MAISI #1786

merged 40 commits into from
Aug 16, 2024

Conversation

Can-Zhao
Copy link
Contributor

Fixes # .

Description

Remove repeated definition in MAISI

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Can-Zhao and others added 30 commits August 12, 2024 06:06
@Can-Zhao
change mor_op position, rm generative import in vae
f544302 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
rm xformer import in vae
9da99fb 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
add load ckpt functions, inference notebook can run
dcad093 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
148484b 
for more information, see https://pre-commit.ci
@Can-Zhao
fix logging format, add inference script, add details in readme
a551102 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
966583f 
for more information, see https://pre-commit.ci
@Can-Zhao
fix typo
4c9c780 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
Merge branch 'refactor_maisi' of https://github.com/Can-Zhao/tutorials …
0b3e3dc 
…into refactor_maisi
@Can-Zhao
update readme
1272254 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
a45c9f9 
for more information, see https://pre-commit.ci
@Can-Zhao
reformat
4af5f5a 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
update readme
4aa9401 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
clear directory in code
b392528 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
a8ca930 
for more information, see https://pre-commit.ci
@Can-Zhao
clear directory in code
b0dda95 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
Merge branch 'refactor_maisi' of https://github.com/Can-Zhao/tutorials …
1bc2a7d 
…into refactor_maisi
@Can-Zhao
change epoch to 1 to save notebook run time
094e938 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
rm controllable size in inference input
6b064d1 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
mv some description to Readme, use subset of data to train in noteboo…
fb080de 
…k to save time

Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
rm dir info
5b942f1 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
rm xformer
837cfb7 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
rm generative in sample.py, clean print in utils.py
04a78bf 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
e97a51d 
for more information, see https://pre-commit.ci
@Can-Zhao
clean legacy code in utils.py
d5dbabe 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
Merge branch 'refactor_maisi' of https://github.com/Can-Zhao/tutorials …
1b287fe 
…into refactor_maisi
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
11be5ba 
for more information, see https://pre-commit.ci
@Can-Zhao
rm repeated comment, rm xformer description, rm generative repo descr…
c223fad 
…iption

Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
daf5c2b 
for more information, see https://pre-commit.ci
@Can-Zhao
rm xformer description
402f4c0 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
Merge branch 'main' into refactor_maisi
3c178c8
Can-Zhao and others added 10 commits August 13, 2024 15:35
@Can-Zhao
change docstring
288e73d 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
Merge branch 'refactor_maisi' of https://github.com/Can-Zhao/tutorials …
2659218 
…into refactor_maisi
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
4e774bc 
for more information, see https://pre-commit.ci
@Can-Zhao
Merge branch 'main' into refactor_maisi
0835773
@Can-Zhao
refactor for new controlnet
c56b0f2 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
Merge branch 'refactor_maisi' of https://github.com/Can-Zhao/tutorials …
b91b83c 
…into refactor_maisi
@Can-Zhao
refactor inference
59907c4 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
7b3c389 
for more information, see https://pre-commit.ci
@Can-Zhao
Merge branch 'Project-MONAI:main' into refactor_maisi
ea82c1c
@Can-Zhao
rm duplicate define
c88bdd4 
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao Can-Zhao marked this pull request as ready for review August 16, 2024 01:28
@Can-Zhao Can-Zhao requested a review from KumoLiu August 16, 2024 01:28
@Can-Zhao Can-Zhao mentioned this pull request Aug 16, 2024
Merged
5 tasks
@KumoLiu KumoLiu merged commit 03ff5c5 into Project-MONAI:main Aug 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KumoLiu KumoLiu KumoLiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Can-Zhao @KumoLiu