Skip to content

deprecate acceleration/multi_gpu_test.ipynb #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 26, 2023
Merged

deprecate acceleration/multi_gpu_test.ipynb #1532

merged 3 commits into from
Sep 26, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Sep 25, 2023

fixes #1528
multigpu workflows should typically follow

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

fixes #1528

Signed-off-by: Wenqi Li <831580+wyli@users.noreply.github.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

wyli and others added 2 commits September 25, 2023 20:56
Signed-off-by: Wenqi Li <831580+wyli@users.noreply.github.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from Nic-Ma and KumoLiu September 25, 2023 19:57
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, LGTM.

@KumoLiu KumoLiu merged commit 7abd995 into main Sep 26, 2023
@wyli wyli deleted the wyli-patch-1 branch September 29, 2023 11:05
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
fixes Project-MONAI#1528
multigpu workflows should typically follow
-
https://github.com/Project-MONAI/tutorials/blob/main/acceleration/distributed_training/unet_training_workflows.py
-
https://github.com/Project-MONAI/model-zoo/blob/dev/models/spleen_ct_segmentation/configs/multi_gpu_train.json

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [ ] Avoid including large-size files in the PR.
- [ ] Clean up long text outputs from code cells in the notebook.
- [ ] For security purposes, please check the contents and remove any
sensitive info such as user names and private key.
- [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use
relative paths for tutorial repo files (3) put figure and graphs in the
`./figure` folder
- [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>`

---------

Signed-off-by: Wenqi Li <831580+wyli@users.noreply.github.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

acceleration/multi_gpu_test.ipynb
2 participants