Skip to content

Create aws_healthimaging.md #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Conversation

flamingofugang
Copy link
Contributor

This is a new platform on AWS using MONAI deploy with native services like AWS HealthImaging and Amazon SageMaker

This is a new platform on AWS using MONAI deploy with native services like AWS HealthImaging and Amazon SageMaker

Signed-off-by: Gang Fu <ganfu@amazon.com>
@dbericat dbericat requested review from dbericat and MMelQin August 23, 2023 16:09
Copy link
Member

@dbericat dbericat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So great to finally see this! :)

Please:

  1. Add a folder aws_healthlakeimaging and move .md there
  2. add architecture diagram to the md (same as in your aws-samples.
  3. Please add link to MONAI Application Package (MAP) to https://github.com/Project-MONAI/monai-deploy/blob/main/guidelines/monai-application-package.md

@MMelQin
Copy link
Collaborator

MMelQin commented Aug 24, 2023

@flamingofugang Hi Steve, thanks for the pull request. There is one important piece information that I'd need to share with you. A new App SDK version, 0.6.0, is about to be released. This version introduces breaking changes. So, in order to keep the AWS HealthImaging Jupyter notebooks working, instead of pip install --upgrade -q "monai" "monai-deploy-app-sdk", we'd actually need to ping the App SDK version to ~=0.5.1. We'll consider update the code once v0.6.0 is released.

Gang Fu and others added 2 commits August 28, 2023 08:31
Added MAP to the link

Signed-off-by: David Bericat <dbericat@nvidia.com>
Copy link
Member

@dbericat dbericat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@MMelQin MMelQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks.

@MMelQin
Copy link
Collaborator

MMelQin commented Aug 28, 2023

@flamingofugang Hi Steve, please sign off per DCO check suggests. I can help merge the PR once the contribution is attributed to you with you signing off the PR.

@MMelQin MMelQin merged commit 7128a1c into Project-MONAI:main Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants