Skip to content

Update Read The Docs configuration to support Python 3.8 #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2023
Merged

Update Read The Docs configuration to support Python 3.8 #439

merged 2 commits into from
Jul 13, 2023

Conversation

gigony
Copy link
Collaborator

@gigony gigony commented Jul 13, 2023

stable image doesn't support Python 3.8, causing the following issue.

Problem in your project's configuration. Invalid "python.version": expected one of (2, 2.7, 3, 3.5, 3.6, 3.7, pypy3.5), got 3.8

https://docs.readthedocs.io/en/stable/config-file/v2.html#build-image-legacy

image

And looks like we are using the old configuration.

This PR updates the configuration to use the latest syntax.

gigony added 2 commits July 12, 2023 17:32
@gigony
Use the latest build image for readthedocs
7039daa 
Signed-off-by: Gigon Bae <gbae@nvidia.com>
@gigony
Use the latest configuration for readthedocs
20c72fa 
Signed-off-by: Gigon Bae <gbae@nvidia.com>
@gigony gigony added the documentation Improvements or additions to documentation label Jul 13, 2023
@gigony gigony requested a review from MMelQin July 13, 2023 01:09
@gigony gigony self-assigned this Jul 13, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

MMelQin
MMelQin approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@MMelQin MMelQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gigon for finding out the issue!

@gigony gigony merged commit 0e5613b into main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MMelQin MMelQin MMelQin approved these changes

Assignees

@gigony gigony

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gigony @MMelQin