Update SDK to support typeguard v3.0 and above, which has a breaking change in its API, and updated notebooks #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eck_type() Along with the SDK change in th io_context.py, any pinged version of typarguard to ~=2 must be removed. Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
With "import --upgrade monai-deploy-app-sdk", users do not need to explicitly uninstall prior version of the App SDK when running the notebook in virtual env. For testing the notebook in dev with the editable App SDK, do NOT use --upgrade in case the local dirty version is lower somehow. Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
…sing the `!r` conversion Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
cumo80
approved these changes
Jul 12, 2023
Signed-off-by: M Q <mingmelvinq@nvidia.com>
mocsharp
approved these changes
Jul 12, 2023
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
|
Kudos, SonarCloud Quality Gate passed!
|
This was
linked to
issues
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key change for this PR is to
During testing, the following changes had to be made
-m pytestinstead of-m py.test--upgradeon importing monai-deploy-app-sdk, so the editable sdk is used, though for users the--upgradeso that they do not need to explicitly uninstall older version of the App SDK)Code coverage only includes the unit tests, not the tests of the notebooks which provide additional and fuller coverage.