-
Notifications
You must be signed in to change notification settings - Fork 52
enable AMD GPU #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable AMD GPU #406
Conversation
Signed-off-by: Vicky Tsang <vtsang@amd.com>
Thank you @vickytsang for the pull request. Do all AMD GPU device names contain the word "AMD"? I have no access to a AMD GPU, and it will be great if you can provide some reference. Also, for the same reason, I cannot test a built package targeting AMD GPU. I have also left comments in the code, mostly on error handling. |
Signed-off-by: Vicky Tsang <vtsang@amd.com>
Signed-off-by: Vicky Tsang <vtsang@amd.com>
I've modified the implementation to use the rocminfo tool to identify the AMD target device. Below is an example of the output given an AMD GPU/rocm enabled system. The rocminfo will return an error if AMD GPU device driver is not loaded or "command not found" if this tool is missing. =====================
|
Signed-off-by: Vicky Tsang <vtsang@amd.com>
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments have been addressed.
We'll merge this PR as experimental support since
|
No description provided.