Skip to content

Update gdown command and missing package #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Update gdown command and missing package #246

merged 1 commit into from
Jan 24, 2022

Conversation

gigony
Copy link
Collaborator

@gigony gigony commented Jan 22, 2022

  • Embrace with quotation" on gdown command to avoid misinterpretation in other shells such as zsh
  • Add missing matplotlib package in the tutorial notebook.

Signed-off-by: Gigon Bae gbae@nvidia.com

Signed-off-by: Gigon Bae <gbae@nvidia.com>
@gigony gigony added the documentation Improvements or additions to documentation label Jan 22, 2022
@gigony gigony added this to the v0.3.0 milestone Jan 22, 2022
@gigony gigony requested a review from MMelQin January 22, 2022 03:33
@gigony gigony self-assigned this Jan 22, 2022
Copy link
Collaborator

@MMelQin MMelQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gigony gigony merged commit 0047739 into main Jan 24, 2022
@gigony gigony mentioned this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants