Fix IPython detection routine #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gigon Bae <gbae@nvidia.com>
|
This discussion on StackOverflow also agrees with your approach. |
MMelQin
approved these changes
Jan 12, 2022
There was a problem hiding this comment.
Looks good and the approach is also regarded as the most robust per stack overflow discussion.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To detect if the code is run inside Jupyter notebook (IPython) or not, it tried to find whether the class's file name starts with
<ipython-or not.Meanwhile the approach worked on Google Colab and some Jupyter Notebook versions. There were some cases where the class's file name is like
/tmp/ipykernel_xxxxx/xxxxxxxxx.pycausing the failure described in #206.This patch uses a different approach.
If the file path is not available, it tries to see each frame information in the stack to check whether the file name ends with "interactiveshell.py" and the function name is "run_code".
If so, it returns
Path("ipython")to notify that the class is defined inside IPython.Fixes #206
Signed-off-by: Gigon Bae gbae@nvidia.com