-
Notifications
You must be signed in to change notification settings - Fork 52
Add Clara Viz operator. #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6c74997
to
0b75f65
Compare
Hey @AndreasHeumann, I tried to read a simple MR image (MNI template) using the monai transform and I wanted to display it on the jupyter notebooks but nothing happens. I followed the documentation here. |
Hi @vikashg. I tried the jupyter notebook you provided and indeed the Python kernel crashes for me as well. But it works if i remove the line |
Hi @AndreasHeumann, So I removed the line
|
The first few lines come from the browser not being able to initialize OpenGL. Did you run the Jupyter Lab command from a ssh connection? Usually I run it on ssh with |
Hi @AndreasHeumann, So yes it works with |
jupyter-lab and jupyter-notebook are using different interfaces for the widgets. Clara Viz should support both, but we had issues with that in the past. I'll check why it does not work with jupyter-notebook. |
I filed NVIDIA/clara-viz#9 for the bug that the Clara Viz widget is not working in Jupyter Notebook (only in Lab). |
@vikashg I just released Clara Viz 0.1.2. That version fixes the crash you were seeing with |
Thanks @AndreasHeumann I will check it out today/tomorrow. |
0b75f65
to
bdbdf48
Compare
bdbdf48
to
8328180
Compare
Signed-off-by: Andreas Heumann <aheumann@nvidia.com>
8328180
to
32a9d10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me, and I tested out this operator in the Spleen Seg App.
Is it fair to say we already have a good Clara Viz operator? @MMelQin what are the plans to update the Jupyter notebooks with it? |
In the upcoming v0.3 release, yes. |
We have to prepare a jupyter notebook for tutorials and maybe update demos 4 and 5 with some clara-viz operators. to fully integrate it. i was making a tutorial. I will update it with spleen segmentation |
Signed-off-by: Andreas Heumann aheumann@nvidia.com