Change the model name in the Spleen seg example dataset to model.ts #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid confusion as the .pt and .ts are used by some model sources to distinguish PyTorch and TorchScript model files, e.g. Clara MMAR. Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
vikashg
approved these changes
Dec 5, 2021
|
@MMelQin do you mind updating the comment with links to both new .zip and old in the Google shared folder? Easier to follow the PR. Also please, add labels and move to 0.3? Thanks! |
|
@dbericat Please see file changes in this PR; the zip link is encoded, adding them in the comment does not help much at all. The diff shows exactly what have changed. |
|
My bad @MMelQin. You are right. Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid confusion as the .pt and .ts are used by some model sources to distinguish PyTorch and TorchScript model files, e.g. Clara MMAR.
A new dataset zip file has been uploaded to Google drive, and the Jupyter notebooks in the tutorials have been updated to download the new zip file and use the updated model file name. The original dataset zip file is still available on the Google drive, in case existing version of the Spleen Seg Jupyter notebook is used.
Noted again that Jupyter notebooks 04 and 05 copied some steps from the Spleen Seg; the duplication inevitably causes duplicated effort when the source changes.
Signed-off-by: mmelqin mingmelvinq@nvidia.com