Skip to content

Add notebook demonstrating MONAI inference service #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

KavinKrishnan
Copy link
Collaborator

No description provided.

@KavinKrishnan KavinKrishnan force-pushed the kavink/mis_rsna_chap4_demo branch 2 times, most recently from 3218b2a to d873818 Compare November 23, 2021 20:24
"source": [
"# Deploying Segmentation App with MONAI Inference Service (MIS)\n",
"\n",
"This tutorial begins with creating an organ segmentation application using MONAI App SDK for a PyTorch model that has been trained with MONAI. Then this tutorial transitions into discussing how to deploy the segmentation application with the RESTful [MONAI Inference Service](https://github.com/Project-MONAI/monai-deploy-app-server/blob/main/components/inference-service/README.md).\n",
Copy link
Collaborator

@MMelQin MMelQin Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first sentence should change to a link to the Chapter 03 for building building the MAP.
Actually the 3rd sentence already does this, so the first sentence can be removed.

"With our MIS instance running as a kubernetes pod, we can now submit REST inferencing \n",
"requests to it\n",
"\n",
"We first need to download our input data and compress the dicom files under `/dcm`\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The can mention the earlier chapter as download the test data is done there. If have not done so, then gdown the data.

@MMelQin
Copy link
Collaborator

MMelQin commented Nov 23, 2021

It is better to use MONAI Deploy rather than MOANI, e.g. helm uninstall -> helm uninstall MIS. as there have been comments about the scope. MONAI covers way too broad.

@@ -0,0 +1,2042 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way to make this by reference rather than copy-paste?

"cell_type": "markdown",
"metadata": {},
"source": [
"# Full Tutorial Building and Deploying Segmentation App with MONAI Inference Service (MIS)\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no way to auto import the previous two chapters, please add a note at the beginning of this chapter to state that the content in this chapter is copied from / composed of those in Notebook 03 and 04, and if there are any discrepancies and doubts, please refer to the said chapters.

@gigony
Copy link
Collaborator

gigony commented Nov 24, 2021

@KavinKrishnan Please update commits with signature.

@KavinKrishnan KavinKrishnan reopened this Nov 24, 2021
@KavinKrishnan KavinKrishnan force-pushed the kavink/mis_rsna_chap4_demo branch 2 times, most recently from 9c2c46a to 42f8aeb Compare November 24, 2021 00:29
@KavinKrishnan KavinKrishnan merged commit a7ce0b6 into main Nov 24, 2021
Signed-off-by: kavink <kavink@nvidia.com>
@gigony gigony mentioned this pull request Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants