-
Notifications
You must be signed in to change notification settings - Fork 52
Remove MONAI user ownership on MAP folders #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
867b08b
to
222c48f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed on the approach.
@KavinKrishnan I wonder to what extent does this PR solves the issue described in #202? Do we just want to run the container as root with this PR? |
222c48f
to
897d062
Compare
Yes, and think it is ok. It seems to be a bigger issue having the packager fix permissions in the image around one user In a future MR, we could provide a way for the user to decide the user when packaging the image. However in the meantime, allowing them to run the container this way should suffice. I think the alternative you suggested with |
Generally for application security, especially FS access controls, use a group to grant permissions to the resources, and on deployment and at runtime, a specific service account just needs to be in this defined group. The application package does not need to pin down the specific user, which is a deployment/runtime concern. Application understands the required permission or ACL of the application specific resources (Docker image files etc, and the mapped folder on host), what specific group, and service account, to use is more the deployment platform configuration concern, to ensure the service account has the required permissions to the resources, without being granted elevated privilege. |
791f897
to
ad5d3d0
Compare
Signed-off-by: kavink <kavink@nvidia.com>
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
With this patch, when running locally, output file would have a root permission that user needs to remove with sudo
method.
Let's merge this and follow up on this issue later.
Merge this PR for now, with the understanding of having #202 to address the account and permission issue. |
The functionaly was removed by #199. This patch revert it.
Removing fixed
monai
user/privilege's on application package image