Skip to content

Correct the place to save input image file as well as correct application class name #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

MMelQin
Copy link
Collaborator

@MMelQin MMelQin commented Oct 20, 2021

Correct the place to save input image, i.e. after loading the image and before pixel manipulation.
Also corrected the class name of a the liver tumor segapplication.

@MMelQin MMelQin force-pushed the mqin/correctly_saving_input_image_for_rendering branch from ffc7359 to bd04732 Compare October 20, 2021 05:04
…tion name

Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
@MMelQin MMelQin requested a review from gigony October 20, 2021 05:05
@MMelQin MMelQin self-assigned this Oct 20, 2021
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #188 (bd04732) into main (c6b9ab1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #188   +/-   ##
=======================================
  Coverage   35.10%   35.10%           
=======================================
  Files          64       64           
  Lines        3096     3096           
=======================================
  Hits         1087     1087           
  Misses       2009     2009           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6b9ab1...bd04732. Read the comment docs.

Copy link
Collaborator

@gigony gigony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@MMelQin MMelQin merged commit e733d94 into main Oct 20, 2021
@gigony gigony mentioned this pull request Oct 25, 2021
@MMelQin MMelQin deleted the mqin/correctly_saving_input_image_for_rendering branch February 3, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants