Skip to content

Add a temporary publishing operator for Clara Render Server before the App SDK viz module is ready #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 12, 2021

Conversation

MMelQin
Copy link
Collaborator

@MMelQin MMelQin commented Oct 12, 2021

This PR is to added the PublisherOperator which publishes the density and mask image dataset for the Clara Render Server, before the App SDK's own viz module/operator is ready.

This interim operator is needed so that high quality 3D rendering of images can be done with off the shelf Clara Render Server. When the App SDK's own version is available, this operator will be updated or likely deprecated.

@MMelQin MMelQin requested a review from gigony October 12, 2021 05:44
@MMelQin MMelQin force-pushed the mqin/add_temp_publishing_operator branch from 6c59c9f to 6579216 Compare October 12, 2021 21:41
…er server.

Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #173 (6579216) into main (14544da) will decrease coverage by 0.10%.
The diff coverage is 27.90%.

❗ Current head 6579216 differs from pull request most recent head 5610891. Consider uploading reports for the commit 5610891 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
- Coverage   35.37%   35.27%   -0.11%     
==========================================
  Files          63       64       +1     
  Lines        3036     3079      +43     
==========================================
+ Hits         1074     1086      +12     
- Misses       1962     1993      +31     
Impacted Files Coverage Δ
monai/deploy/operators/publisher_operator.py 26.19% <26.19%> (ø)
monai/deploy/operators/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90d15ca...5610891. Read the comment docs.

Copy link
Collaborator

@gigony gigony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants