Skip to content

Fixes some issues with code formatter #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 30, 2017
Merged

Conversation

kapilmb
Copy link

@kapilmb kapilmb commented Jan 30, 2017

Fixes the following issues:

  • If the user switches the active editor when code formatter is running, the formatter can write to the new active editor.
  • If the user executes "format document" on a document when the document is already being formatted, the extension creates a redundant request for formatting the same document.
  • If for any reason PSES crashes, then the formatting status is not cleaned up from the status bar.

Kapil Borle added 7 commits January 25, 2017 16:40
A user can execute `Format Document` command on a document even if the same document is already being formatted. This sends another, redundant, formatting request to the server for the same file. Another annoying side effect is that a new formatting status for the same file gets created on the status bar.
If formatting is in progress in a given editor and if we change the active editor then the correction edits can get written to the new active editor.
@daviwil
Copy link
Contributor

daviwil commented Jan 30, 2017

Sweet, thanks!

@daviwil daviwil merged commit 3c7a723 into develop Jan 30, 2017
@daviwil daviwil deleted the kapilmb/formatter-fixes branch January 30, 2017 21:54
@kapilmb
Copy link
Author

kapilmb commented Jan 30, 2017

Thanks @daviwil!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants