Skip to content

Fix title of PowerShell Command Explorer pane #3866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

andyleejordan
Copy link
Member

It's no longer in preview, and the title was repetitive.

This probably won't break anyone (unless they bound a keyboard shortcut to this particular view, which both seems unlikely and I didn't see anything on a search of GitHub indicating anyone was doing this).

It's no longer in preview, and the title was repetitive.
@andyleejordan
Copy link
Member Author

It was poorly named and it made things crowded in the UI. Technically we could change the title without changing the name but then they'd be confusingly out of sync, and it's better to do it sooner than later (especially since the title has included "Preview" in it).

Before:

Screen Shot 2022-03-04 at 4 33 24 PM

After:

Screen Shot 2022-03-04 at 4 34 49 PM

@andyleejordan andyleejordan marked this pull request as ready for review March 5, 2022 00:35
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think that's safe. At the very least it'll be easy to fix for the small handful who might have something set up.

LGTM

@andyleejordan andyleejordan merged commit cc2c6eb into master Mar 7, 2022
@andyleejordan andyleejordan deleted the andschwa/command-explorer branch March 7, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UI Issue-Enhancement A feature request (enhancement).
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants