Session menu fails to open when PowerShell extension is starting #2973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test failures are not your fault. I'll look into those |
|
Thanks @TylerLeonhardt like I said it built out fine locally :) |
|
OH I also I chose master, because I didn't really know what branch to use, wasn't really sure how to progress from there. |
|
master is correct. |
rjmholt
approved these changes
Sep 28, 2020
|
Given the low risk of this change, and the test failures are happening in master already... I'll merge this in |
TylerLeonhardt
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is the solution proposed by @GaelGirodon in Issue #2906
There were no issues during the build and testing of this change, and the proper version of powershell was loaded and displayed in the task bar.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready