Address Notebook breaking changes #2827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
commented
Jul 22, 2020
| @@ -79,9 +79,6 @@ jobs: | |||
| # Remove the old file so it doesn't get picked up by tsc | |||
| Remove-Item ./old.vscode.proposed.d.ts -Force | |||
|
|
|||
| - name: Compile the TypeScript to check for errors | |||
There was a problem hiding this comment.
Removed this because PRs should still get sent even if it doesn't compile.
rjmholt
approved these changes
Jul 22, 2020
|
@rjmholt one quick additional commit |
rjmholt
approved these changes
Jul 23, 2020
TylerLeonhardt
force-pushed
the
address-notebook-breaking-changes
branch
from
5d0cbdc to
3474b30
Compare
rjmholt
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
See the changes in vscode.proposed.d.ts...
Basically, they added more methods to the
vscode.NotebookKernelinterface so I wanted to separate it out into another class...also, now we need a
vscode.NotebookKernelProviderinstead of just setting thekernelon thevscode.NotebookContentProviderPR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready