Skip to content

Add new Pester 5 GA Output Types #2726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2020
Merged

Add new Pester 5 GA Output Types #2726

merged 1 commit into from
May 28, 2020

Conversation

JustinGrote
Copy link
Collaborator

@JustinGrote JustinGrote commented May 27, 2020

New Pester 5 Output Types were added last-minute to GA. These should also be available in the extension pester settings options.
https://github.com/pester/Pester/blob/v5.0/README.md#actual-breaking-changes

PR Summary

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

New Pester 5 Output Types were added last-minute to GA. These should also be available in the extension.
https://github.com/pester/Pester/blob/v5.0/README.md#actual-breaking-changes
@JustinGrote
Copy link
Collaborator Author

@TylerLeonhardt FYI the build appears to be failing for external reason to this change.

@TylerLeonhardt
Copy link
Member

Yep I'm working on that

@TylerLeonhardt
Copy link
Member

cc @nohwnd for visibility.

@TylerLeonhardt
Copy link
Member

@JustinGrote we should probably add the appropriate values to this switch:

https://github.com/PowerShell/vscode-powershell/blob/master/InvokePesterStub.ps1#L80-L84

@nohwnd
Copy link
Contributor

nohwnd commented May 28, 2020

@JustinGrote @TylerLeonhardt that switch is okay, the default output for v4 should be All, which it is.

The command help does not mention all the options, so imho this is good to go :)

@TylerLeonhardt TylerLeonhardt merged commit a210bb4 into PowerShell:master May 28, 2020
@TylerLeonhardt
Copy link
Member

Thanks @JustinGrote!

@JustinGrote JustinGrote deleted the patch-1 branch May 28, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants