Skip to content

🐛 Respect user choice when dismissing the powerShellExePath dialog #2688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2020

Conversation

bergmeister
Copy link
Contributor

PR Summary

Currently the extension actually changes the user's powerShellExePath if the user dismisses the presented dialog by clicking on the x button.
The VS-Code API vscode.window.showWarningMessage(message: string, items: string[]) returns undefined when the user dismisses the dialog: https://code.visualstudio.com/api/references/vscode-api#window.showWarningMessage
image

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@bergmeister bergmeister changed the title Respect user choice when dismissing the powerShellExePath dialog 🐛 Respect user choice when dismissing the powerShellExePath dialog May 10, 2020
@TylerLeonhardt
Copy link
Member

Hmmm I feel like they changed the API... But LGTM

@bergmeister
Copy link
Contributor Author

bergmeister commented May 10, 2020

Hmmm I feel like they changed the API... But LGTM

I doubt it, their code hasn't changed since they added it 3 years ago here (comments are still the same) and I even looked 2 layers down to when it calls extHostMessageService.showMessage.

@TylerLeonhardt TylerLeonhardt merged commit c59f3eb into PowerShell:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants