You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turned off by default to reduce potential impact if people don't like it or should there be bugs. PR ready but pending PSSA release.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.
PR has a meaningful title
Summarized changes
PR has tests
This PR is ready to merge and is not work in progress
If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready
@TylerLeonhardt I will move this PR into the other to have only 1 PSSA 1.19.0 PR.
Just one question: We already have the powershell.codeFormatting.whitespaceAroundPipe setting that removes extraneous whitespace or adds whitespace if needed. With the new changes in PSSA this functionality will be split into two settings: The existing one will only add missing whitespace (and remain enabled by default) and the new setting will only remove extranuous whitespace and will be disabled by default. I was thinking of calling the new setting trimWhitespaceAroundPipe but for clarity could we consider renaming the existing one from whitespaceAroundPipe to missingWhitespaceAroundPipe or would you rather not rename an existing setting?
bergmeister
changed the title
Add CheckPipeForRedundantWhitespace option for PSSA 1.19: powershell.codeFormatting.trimWhitespaceAroundPipe
WIP Add CheckPipeForRedundantWhitespace option for PSSA 1.19: powershell.codeFormatting.trimWhitespaceAroundPipe
Mar 4, 2020
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bergmeister
changed the title
PR Summary
Turned off by default to reduce potential impact if people don't like it or should there be bugs. PR ready but pending PSSA release.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready