Skip to content

Use powerShellDefaultVersion everywhere and stop using powerShellExePath #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 26, 2019
Merged

Use powerShellDefaultVersion everywhere and stop using powerShellExePath #2304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c7f97c5
Use powerShellDefaultVersion everywhere and stop using powerShellExePath
TylerLeonhardt Nov 13, 2019
600de8c
add modify settings in session menu
TylerLeonhardt Nov 14, 2019
47ccbba
re-add powerShellExePath to package.json so vscode api can update it …
TylerLeonhardt Nov 14, 2019
01c4a2b
actually use setting...
TylerLeonhardt Nov 14, 2019
92a496b
still switch even if workspace setting is set
TylerLeonhardt Nov 14, 2019
b598f7c
rob's feedback
TylerLeonhardt Nov 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,12 +499,6 @@
"default": [],
"description": "Specify array of Modules to exclude from Command Explorer listing."
},
"powershell.powerShellExePath": {
"type": "string",
"default": "",
"scope": "machine",
"description": "Specifies the full path to a PowerShell executable. Changes the installation of PowerShell used for language and debugging services."
},
"powershell.powerShellAdditionalExePaths": {
"type": "array",
"description": "Specifies an array of versionName / exePath pairs where exePath points to a non-standard install location for PowerShell and versionName can be used to reference this path with the powershell.powerShellDefaultVersion setting.",
Expand All @@ -530,7 +524,13 @@
},
"powershell.powerShellDefaultVersion": {
"type": "string",
"description": "Specifies the PowerShell version name, as displayed by the 'PowerShell: Show Session Menu' command, used when the extension loads e.g \"Windows PowerShell (x86)\" or \"PowerShell Core 6 (x64)\"."
"description": "Specifies the PowerShell version name, as displayed by the 'PowerShell: Show Session Menu' command, used when the extension loads e.g \"Windows PowerShell (x86)\" or \"PowerShell Core 6 (x64)\". You can specify additional PowerShell executables by using the \"powershell.powerShellAdditionalExePaths\" setting."
},
"powershell.powerShellExePath": {
"type": "string",
"default": "",
"scope": "machine",
"description": "REMOVED. Please use the \"powershell.powerShellDefaultVersion\" setting instead."
},
"powershell.promptToUpdatePowerShell": {
"type": "boolean",
Expand Down
2 changes: 1 addition & 1 deletion src/features/GenerateBugReport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ ${tableHeader}\n${table};

private getRuntimeInfo() {

const powerShellExePath = this.sessionManager.getPowerShellExePath();
const powerShellExePath = this.sessionManager.PowerShellExeDetails.exePath;
const powerShellArgs = [
"-NoProfile",
"-Command",
Expand Down
Loading